Bug 243621

Summary: [Painting] Do not call textRunOffsetFromBottomMost() unless the resolved underline position value is TextUnderlinePosition::Under
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, koivisto, mmaxfield, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 243766    
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2022-08-05 22:45:44 PDT
textRunOffsetFromBottomMost() is expensive
Attachments
Patch (13.21 KB, patch)
2022-08-05 22:57 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (12.75 KB, patch)
2022-08-06 14:12 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-08-05 22:57:30 PDT
Created attachment 461436 [details] Patch
zalan
Comment 2 2022-08-06 14:12:28 PDT
Created attachment 461445 [details] Patch
EWS
Comment 3 2022-08-06 16:31:32 PDT
Committed 253186@main (3f94a77b8952): <https://commits.webkit.org/253186@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461445 [details].
Radar WebKit Bug Importer
Comment 4 2022-08-06 16:32:16 PDT
<rdar://problem/98254665>
Note You need to log in before you can comment on or make changes to this bug.