| Summary: | Make '-webkit-background-size' a legacy shorthand | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> |
| Component: | Forms | Assignee: | Aditya Keerthi <akeerthi> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | akeerthi, cdumez, ntim, webkit-bug-importer, wenson_hsieh |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 240341 | ||
|
Description
Tim Nguyen (:ntim)
2022-08-04 15:24:15 PDT
One of the issues is: https://github.com/web-platform-tests/wpt/issues/35333. The other issue is that the list of "fallback-props" in https://github.com/web-platform-tests/wpt/blob/19d452e70a/css/css-ui/compute-kind-widget-no-fallback-props-001.html, does not include `-webkit-background-size`, in addition to `background-size`, causing the `borderAndBackgroundEquals` check to fail, dropping native appearance. The test and the spec likely need to be updated. (In reply to Aditya Keerthi from comment #2) > The other issue is that the list of "fallback-props" in > https://github.com/web-platform-tests/wpt/blob/19d452e70a/css/css-ui/compute- > kind-widget-no-fallback-props-001.html, does not include > `-webkit-background-size`, in addition to `background-size`, causing the > `borderAndBackgroundEquals` check to fail, dropping native appearance. The proper way to fix this would be making `-webkit-background-size` a legacy shorthand of `background-size` rather than implementing it as a related property. An example of this is bug 104805. I have a patch in progress to make `-webkit-background-size` a legacy shorthand. This actually makes appearance behave correctly, however, the test still fails. We will also need to fix the intrinsic margins issue (https://bugs.webkit.org/show_bug.cgi?id=107380) in order to get this test passing. I confirmed that with my background-size patch, and with Chris' patch in https://bugs.webkit.org/show_bug.cgi?id=107380, this test finally passes. Pull request: https://github.com/WebKit/WebKit/pull/3372 Committed 254925@main (856140e9a06f): <https://commits.webkit.org/254925@main> Reviewed commits have been landed. Closing PR #3372 and removing active labels. |