Bug 243548

Summary:	[ews] merge-queue fails to find reviewer on GitHub PRs with lots of review activity
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, ap, cdumez, jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari 13
Hardware:	Unspecified
OS:	Unspecified

Description Ryan Haddad 2022-08-04 09:15:10 PDT

merge-queue fails to find reviewer on GitHub PRs with lots of review activity because our tooling doesn't handle the case where API results become paginated

This was seen with the following PRs:
https://github.com/WebKit/WebKit/pull/2741
https://github.com/WebKit/WebKit/pull/2417

Comment 1 Radar WebKit Bug Importer 2022-08-04 09:15:37 PDT

<rdar://problem/98129710>

Comment 2 Aakash Jain 2022-08-04 09:18:38 PDT

For reference, corresponding buildbot builds with the issue: 
https://ews-build.webkit.org/#/builders/74/builds/2040
https://ews-build.webkit.org/#/builders/74/builds/2175

GitHub api which Merge-Queue use (e.g.: https://api.github.com/repos/Webkit/WebKit/pulls/2741/reviews) wasn't listing the APPROVED state since it got paginated.

Comment 3 Jonathan Bedard 2022-11-10 11:24:53 PST

Pull request: https://github.com/WebKit/WebKit/pull/6355

Comment 4 EWS 2022-11-16 14:42:54 PST

Committed 256752@main (42fd020fc0c3): <https://commits.webkit.org/256752@main>

Reviewed commits have been landed. Closing PR #6355 and removing active labels.