Bug 243534

Summary: [CSS contain] Fix handling of layout/paint containment with internal ruby boxes
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, clopez, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, ntim, pdr, simon.fraser, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: Safari 15   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/35338
Bug Depends on: 240906    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch ews-feeder: commit-queue-

Description Rob Buis 2022-08-04 04:15:34 PDT 
Fix handling of layout/paint containment with ruby.
Comment 1 Rob Buis 2022-08-04 04:17:58 PDT 
Created attachment 461396 [details]
Patch
Comment 2 EWS Watchlist 2022-08-04 04:19:51 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Tim Nguyen (:ntim) 2022-08-04 05:41:35 PDT 
Comment on attachment 461396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461396&action=review

> LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-017.html:7
> +<meta name="fuzzy" content="maxDifference=0-3; totalPixels=0-6738" />

Why do we need so many fuzzy pixels?
Comment 4 Rob Buis 2022-08-04 05:55:03 PDT 
Comment on attachment 461396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461396&action=review

>> LayoutTests/imported/w3c/web-platform-tests/css/css-contain/contain-layout-017.html:7
>> +<meta name="fuzzy" content="maxDifference=0-3; totalPixels=0-6738" />
> 
> Why do we need so many fuzzy pixels?

Quite sure we do not need that many, I had a 1 pixel difference locally. However also locally no fuzzy value for me fixed the test. So now I am wondering what the bots will say, let's see!
Comment 5 Rob Buis 2022-08-04 07:06:56 PDT 
Created attachment 461398 [details]
Patch
Comment 6 Radar WebKit Bug Importer 2022-08-04 15:52:52 PDT 
<rdar://problem/98153015>
Comment 7 Tim Nguyen (:ntim) 2022-08-08 14:03:39 PDT 
Comment on attachment 461398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461398&action=review

> Source/WebCore/rendering/RenderLayer.cpp:584
> +    return !renderer().style().hasAutoUsedZIndex() || renderer().shouldApplyLayoutOrPaintContainment({ Containment::Layout, Containment::Paint }) | isRenderViewLayer();

I don't think you wanted to do the bitwise operator |

|| ?
Comment 8 Rob Buis 2022-08-08 14:14:53 PDT 
Created attachment 461492 [details]
Patch
Comment 9 Rob Buis 2022-08-08 14:15:36 PDT 
Comment on attachment 461398 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461398&action=review

>> Source/WebCore/rendering/RenderLayer.cpp:584
>> +    return !renderer().style().hasAutoUsedZIndex() || renderer().shouldApplyLayoutOrPaintContainment({ Containment::Layout, Containment::Paint }) | isRenderViewLayer();
> 
> I don't think you wanted to do the bitwise operator |
> 
> || ?

Well spotted, thnx! Fixed.
Comment 10 EWS 2022-08-11 09:48:59 PDT 
No reviewer information in commit message, blocking PR #None
Comment 11 Rob Buis 2022-08-11 10:24:31 PDT 
Created attachment 461543 [details]
Patch
Comment 12 Rob Buis 2022-08-11 11:24:40 PDT 
Created attachment 461544 [details]
Patch
Comment 13 EWS 2022-08-11 17:02:11 PDT 
Committed 253354@main (6d0e1e4280d9): <https://commits.webkit.org/253354@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461544 [details].