Bug 243527

Summary: contain-size-select-001.html and contain-size-select-002.html are failing
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mifenton, pdr, rbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Tim Nguyen (:ntim) 2022-08-03 20:21:57 PDT 
imported/w3c/web-platform-tests/css/css-contain/contain-size-select-001.html
imported/w3c/web-platform-tests/css/css-contain/contain-size-select-002.html

are failing.

The comment above the test expectations is: 

# 1. The height driven by the imaginary box (strut) does not match the minimum height value set in the RenderTheme (e.g. see RenderThemeMac::adjustMenuListButtonStyle).
# 2. We ignore the background-color property value (supposed to be white on white to renderer "blank" content).

For 1: https://searchfox.org/wubkat/rev/05871f6631c8518ecc69dccec80d850e6ad3fad8/Source/WebCore/rendering/RenderThemeMac.mm#1692-1703
Comment 1 Radar WebKit Bug Importer 2022-08-03 20:22:26 PDT 
<rdar://problem/98096620>
Comment 2 Rob Buis 2022-08-05 13:06:32 PDT 
Created attachment 461429 [details]
Patch
Comment 3 Rob Buis 2022-08-05 14:23:49 PDT 
Created attachment 461431 [details]
Patch
Comment 4 Aditya Keerthi 2022-08-05 16:51:11 PDT 
These tests still fail on macOS.
Comment 5 Rob Buis 2022-08-05 23:10:45 PDT 
(In reply to Aditya Keerthi from comment #4)
> These tests still fail on macOS.

I was misled by your comment on https://bugs.webkit.org/show_bug.cgi?id=243466 :)
Comment 6 Tim Nguyen (:ntim) 2022-08-06 19:33:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3080
Comment 7 Rob Buis 2022-08-07 03:40:42 PDT 
Created attachment 461461 [details]
Patch
Comment 8 Rob Buis 2022-08-07 08:13:34 PDT 
Created attachment 461464 [details]
Patch
Comment 9 Tim Nguyen (:ntim) 2022-08-07 23:43:27 PDT 
Comment on attachment 461464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461464&action=review

> Source/WebCore/rendering/RenderMenuList.cpp:250
> +    if (!shouldApplySizeContainment()) {

I personally disagree with this change, see https://github.com/WebKit/WebKit/pull/3080#issuecomment-1207729203
Comment 10 EWS 2022-08-08 10:14:45 PDT 
Committed 253218@main (5a258b32387e): <https://commits.webkit.org/253218@main>

Reviewed commits have been landed. Closing PR #3080 and removing active labels.