Bug 243527

Summary: contain-size-select-001.html and contain-size-select-002.html are failing
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mifenton, pdr, rbuis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Tim Nguyen (:ntim)
Reported 2022-08-03 20:21:57 PDT
imported/w3c/web-platform-tests/css/css-contain/contain-size-select-001.html imported/w3c/web-platform-tests/css/css-contain/contain-size-select-002.html are failing. The comment above the test expectations is: # 1. The height driven by the imaginary box (strut) does not match the minimum height value set in the RenderTheme (e.g. see RenderThemeMac::adjustMenuListButtonStyle). # 2. We ignore the background-color property value (supposed to be white on white to renderer "blank" content). For 1: https://searchfox.org/wubkat/rev/05871f6631c8518ecc69dccec80d850e6ad3fad8/Source/WebCore/rendering/RenderThemeMac.mm#1692-1703
Attachments
Patch (1.54 KB, patch)
2022-08-05 13:06 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (1.79 KB, patch)
2022-08-05 14:23 PDT, Rob Buis 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (4.68 KB, patch)
2022-08-07 03:40 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (4.96 KB, patch)
2022-08-07 08:13 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-08-03 20:22:26 PDT
<rdar://problem/98096620>
Rob Buis
Comment 2 2022-08-05 13:06:32 PDT
Created attachment 461429 [details] Patch
Rob Buis
Comment 3 2022-08-05 14:23:49 PDT
Created attachment 461431 [details] Patch
Aditya Keerthi
Comment 4 2022-08-05 16:51:11 PDT
These tests still fail on macOS.
Rob Buis
Comment 5 2022-08-05 23:10:45 PDT
(In reply to Aditya Keerthi from comment #4) > These tests still fail on macOS. I was misled by your comment on https://bugs.webkit.org/show_bug.cgi?id=243466 :)
Tim Nguyen (:ntim)
Comment 6 2022-08-06 19:33:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3080
Rob Buis
Comment 7 2022-08-07 03:40:42 PDT
Created attachment 461461 [details] Patch
Rob Buis
Comment 8 2022-08-07 08:13:34 PDT
Created attachment 461464 [details] Patch
Tim Nguyen (:ntim)
Comment 9 2022-08-07 23:43:27 PDT
Comment on attachment 461464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461464&action=review > Source/WebCore/rendering/RenderMenuList.cpp:250 > + if (!shouldApplySizeContainment()) { I personally disagree with this change, see https://github.com/WebKit/WebKit/pull/3080#issuecomment-1207729203
EWS
Comment 10 2022-08-08 10:14:45 PDT
Committed 253218@main (5a258b32387e): <https://commits.webkit.org/253218@main> Reviewed commits have been landed. Closing PR #3080 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.