Bug 243385

Summary:	srcdoc iframes fail to clear when srcdoc attribute removed
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Frames	Assignee:	Ryosuke Niwa <rniwa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, bfulgham, karlcow, rniwa, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, InRadar
Version:	Safari 15
Hardware:	Mac (Apple Silicon)
OS:	macOS 12
URL:	http://wpt.live/html/semantics/embedded-content/the-iframe-element/srcdoc-attribute-reset.html

Description Ahmad Saleem 2022-07-31 02:47:15 PDT

Hi Team,

As of right now, Safari is only browser to fail following WPT test:

https://wpt.fyi/results/html/semantics/embedded-content/the-iframe-element/srcdoc-attribute-reset.html?label=master&label=experimental&aligned&q=srcdoc-attribute-reset

Link to test - http://wpt.live/html/semantics/embedded-content/the-iframe-element/srcdoc-attribute-reset.html

While all other browser pass this test case, I tried to look into bug whether it is already reported or not but I was not able to find. Hence, I am raising this bug and just to bring to attention (if bug already exist, please mark it as duplicate).

This was fixed in Chrome in following - https://bugs.chromium.org/p/chromium/issues/detail?id=1233143

Thanks for continuous work in improving Webkit.. Keep going strong!

Comment 1 Ryosuke Niwa 2022-07-31 12:00:03 PDT

lol, this is because of the following code:

void HTMLFrameElementBase::parseAttribute(const QualifiedName& name, const AtomString& value)
{
    if (name == srcdocAttr) {
        if (value.isNull()) {
            const AtomString& srcValue = attributeWithoutSynchronization(srcAttr);
            if (!srcValue.isNull())
                setLocation(stripLeadingAndTrailingHTMLSpaces(srcValue));
        } else

Comment 2 Ryosuke Niwa 2022-07-31 12:07:37 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2889

Comment 3 Radar WebKit Bug Importer 2022-07-31 18:40:06 PDT

<rdar://problem/97885726>

Comment 4 EWS 2022-07-31 19:03:36 PDT

Committed 252991@main (e540252620c9): <https://commits.webkit.org/252991@main>

Reviewed commits have been landed. Closing PR #2889 and removing active labels.