| Summary: | check-webkit-style: Suppress runtime/wtf_move and runtime/wtf_make_unique for MiniBrowsers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
| Component: | Tools / Tests | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | b7r.mmxxx, Basuke.Suzuki, darin, don.olmstead, ews-watchlist, glenn, jbedard, ross.kirsling, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 461280 [details]
Patch
Comment on attachment 461280 [details]
Patch
OK, but I think we probably want to do this for MiniBrowser on all platforms. I suspect the reason it doesn’t come up with the Apple platform MiniBrowser versions is that they are not written in C++.
Thank you for the review. It's a good point. mac, gtk, and wpe MiniBrowser also isn't using WTF. Will fix. Created attachment 461285 [details]
[fast-cq] Patch for landing
Committed 252932@main (f156890e65f5): <https://commits.webkit.org/252932@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461285 [details]. |
check-webkit-style: Suppress runtime/wtf_move and runtime/wtf_make_unique for Windows and PlayStation MiniBrowsers > ERROR: Tools/MiniBrowser/playstation/MainWindow.cpp:144: Use 'WTFMove()' instead of 'std::move()'. [runtime/wtf_move] [4] > ERROR: Tools/MiniBrowser/playstation/WebViewWindow.cpp:68: Use 'WTF::makeUnique<WebViewWindow>' instead of 'std::make_unique<WebViewWindow>'. [runtime/wtf_make_unique] [4] Windows and PlayStation MiniBrowsers don't use WTF, try to use only public WebKit API.