Bug 243271

Summary:	EWS should not be triggered for multi-year old patches
Product:	WebKit	Reporter:	Ryan Haddad <ryanhaddad>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, ap, ryanhaddad, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Description Ryan Haddad 2022-07-27 15:57:10 PDT

It was pointed out to me on Slack that EWS jobs were triggered for https://bugs.webkit.org/show_bug.cgi?id=127586, which hasn't been modified since 2014.

Not sure if someone triggered this manually or if it a sign of a bug in our infrastructure.

Example: https://ews-build.webkit.org/#/builders/43/builds/15364

Comment 1 Aakash Jain 2022-07-28 04:26:14 PDT

Logs indicate that Submit to EWS button was pressed on it at 2022-07-27 06:24:07,903 GMT.

It was pressed for both the patches (222545 and 222869) on https://bugs.webkit.org/show_bug.cgi?id=127586

2022-07-27 06:24:07,903 - SubmitToEWS::change: 222545
2022-07-27 06:24:10,702 - SubmitToEWS::change: 222869

Comment 2 Aakash Jain 2022-07-28 04:35:06 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2807

Comment 3 EWS 2022-07-28 09:57:05 PDT

Committed 252916@main (6e27809f8901): <https://commits.webkit.org/252916@main>

Reviewed commits have been landed. Closing PR #2807 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2022-07-28 09:58:16 PDT

<rdar://problem/97728841>

Comment 5 Aakash Jain 2022-07-29 09:18:05 PDT

Deployed on the server. Working fine.

e.g: clicking on "Submit for EWS analysis" button on https://ews.webkit.org/status-bubble/300000/ and https://ews.webkit.org/status-bubble/30000000/ now results in immediate error.