Bug 243210

Summary:

AX ITM: Fix for accessibility/nested-textareas-value-changed-notifications.html in isolated tree mode.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description Andres Gonzalez 2022-07-26 05:54:14 PDT

Currently a timeout.

Comment 1 Radar WebKit Bug Importer 2022-07-26 05:54:23 PDT

<rdar://problem/97601722>

Comment 2 Andres Gonzalez 2022-07-26 06:10:19 PDT

Created attachment 461221 [details]
Patch

Comment 3 chris fleizach 2022-07-26 07:12:31 PDT

Comment on attachment 461221 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461221&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:2373
>      if (!renderer() || !is<Element>(node()))

We don’t need this renderer check here anymore

Comment 4 Andres Gonzalez 2022-07-26 07:48:44 PDT

(In reply to chris fleizach from comment #3)
> Comment on attachment 461221 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=461221&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:2373
> >      if (!renderer() || !is<Element>(node()))
> 
> We don’t need this renderer check here anymore

Down below we do:

    auto& editor = renderer()->frame().editor();

So early return if !renderer() is appropriate.

Comment 5 Tyler Wilcock 2022-07-26 08:57:41 PDT

(In reply to Andres Gonzalez from comment #4)
> (In reply to chris fleizach from comment #3)
> > Comment on attachment 461221 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=461221&action=review
> > 
> > > Source/WebCore/accessibility/AccessibilityObject.cpp:2373
> > >      if (!renderer() || !is<Element>(node()))
> > 
> > We don’t need this renderer check here anymore
> 
> Down below we do:
> 
>     auto& editor = renderer()->frame().editor();
> 
> So early return if !renderer() is appropriate.

This is the RenderObject implementation for frame:

inline Frame& RenderObject::frame() const
{
    return *document().frame();
}

Is it possible to use the node to do something similar, making this function not require a renderer at all? This could improve our display:contents support. Up to you if you would prefer not to address that now though.

Comment 6 EWS 2022-07-27 05:15:20 PDT

Committed 252863@main (f410828332d2): <https://commits.webkit.org/252863@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461221 [details].