| Summary: | [LFC][IFC] Inconsistent integral rounding of baseline relative logical top values | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=243940 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2022-07-25 21:47:57 PDT
Created attachment 461212 [details]
Patch
Created attachment 461222 [details]
Patch
Comment on attachment 461222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461222&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:127 > + void setLogicalTop(InlineLayoutUnit logicalTop) { logicalTop >= 0 ? m_logicalRect.setTop(roundToInt(logicalTop)) : m_logicalRect.setTop(-roundToInt(-logicalTop)); } I think you want ?: inside setTop (In reply to Antti Koivisto from comment #3) > Comment on attachment 461222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461222&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:127 > > + void setLogicalTop(InlineLayoutUnit logicalTop) { logicalTop >= 0 ? m_logicalRect.setTop(roundToInt(logicalTop)) : m_logicalRect.setTop(-roundToInt(-logicalTop)); } > > I think you want ?: inside setTop oops, right. Created attachment 461223 [details]
Patch
Committed 252825@main (c4803567c7f8): <https://commits.webkit.org/252825@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461223 [details]. |