Bug 243078

Summary:	[Wasm-GC] Make GC tests more maintainable
Product:	WebKit	Reporter:	Asumu Takikawa <asumu>
Component:	WebAssembly	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	247394

Description Asumu Takikawa 2022-07-21 14:25:33 PDT

Currently the Wasm GC tests (structs.js and i31.js for example) are written with binary strings with comments indicating the Wasm text format module that they correspond to.

A recent review comment (https://github.com/WebKit/WebKit/pull/2202#discussion_r916963742) suggested improving the situation with a script to ensure the binary format matches the text, to ensure maintainability.

Another possible solution is to embed a text format encoder/decoder that supports the Wasm GC proposal. One way to do this is to compile the Wasm specification reference interpreter to JS, and embed that in the tests. I'll attach a patch that illustrates this approach for the current tests.

Comment 1 Asumu Takikawa 2022-07-21 17:15:08 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2643

Comment 2 EWS 2022-07-26 08:43:24 PDT

Committed 252823@main (52534d6449a4): <https://commits.webkit.org/252823@main>

Reviewed commits have been landed. Closing PR #2643 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-07-26 08:44:17 PDT

<rdar://problem/97608052>