Bug 242976

Summary: AX: Make accessibility/accessibility-node-reparent.html async-friendly so it can pass in ITM
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tyler Wilcock
Reported 2022-07-20 18:58:49 PDT
Make accessibility/accessibility-node-reparent.html so it can pass in ITM
Attachments
Patch (8.92 KB, patch)
2022-07-20 19:01 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (8.87 KB, patch)
2022-07-22 09:24 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-07-20 18:58:58 PDT
<rdar://problem/97353412>
Tyler Wilcock
Comment 2 2022-07-20 19:01:23 PDT
Created attachment 461068 [details] Patch
Andres Gonzalez
Comment 3 2022-07-22 08:26:17 PDT
(In reply to Tyler Wilcock from comment #2) > Created attachment 461068 [details] > Patch --- a/LayoutTests/accessibility/accessibility-node-reparent.html +++ a/LayoutTests/accessibility/accessibility-node-reparent.html +<div id="container" role="group" tabindex="-1"></div> <canvas id="canvas" tabindex="-1"></canvas> Do we need the tabindex attribute? + // Create an ordinary button on the page, focus it and get its accessibility role. We are no longer focusing the button. + return expectedButtonRole !== expectedDetachedRole Missing ;
Tyler Wilcock
Comment 4 2022-07-22 09:23:17 PDT
(In reply to Andres Gonzalez from comment #3) > (In reply to Tyler Wilcock from comment #2) > > Created attachment 461068 [details] > > Patch > > --- a/LayoutTests/accessibility/accessibility-node-reparent.html > +++ a/LayoutTests/accessibility/accessibility-node-reparent.html > > +<div id="container" role="group" tabindex="-1"></div> > > <canvas id="canvas" tabindex="-1"></canvas> > > Do we need the tabindex attribute? We do need it just for the <canvas> element to make it focusable via JS to prevent it from being ignored (which this test relies on). I removed tabindex from the <div> and applied your other comments.
Tyler Wilcock
Comment 5 2022-07-22 09:24:32 PDT
Created attachment 461140 [details] Patch
EWS
Comment 6 2022-07-22 19:36:00 PDT
Committed 252756@main (d1c30db15e8f): <https://commits.webkit.org/252756@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461140 [details].
Note You need to log in before you can comment on or make changes to this bug.