Bug 242928

Summary:	git-webkit pr should update the user's prepare-commit-msg hook if it is outdated
Product:	WebKit	Reporter:	Alan Coon <alancoon>
Component:	Tools / Tests	Assignee:	Alan Coon <alancoon>
Status:	RESOLVED WONTFIX
Severity:	Enhancement	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Description Alan Coon 2022-07-19 18:18:39 PDT

As a form of automatically deploying changes to the prepare-commit-msg hook, git-webkit pr should update the user's prepare-commit-msg hook if it is outdated.
This would remove the necessity of running git-webkit setup again to copy over new changes to the prepare-commit-msg hook.

Comment 1 Radar WebKit Bug Importer 2022-07-19 18:19:05 PDT

<rdar://problem/97292747>

Comment 2 Alan Coon 2022-07-19 18:19:55 PDT

Inspired by changes to prepare-commit-msg in https://bugs.webkit.org/show_bug.cgi?id=242914.

Comment 3 Alan Coon 2022-07-19 19:31:27 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2575

Comment 4 Alan Coon 2022-07-22 14:40:52 PDT

JonWBedard commented 3 days ago
I am a bit hesitant about this as an idea. One of the nice things about git-webkit pr not owning this is that if contributors want, they can modify their own prepare-commit-msg if they want to. I suppose that's a bit counter to the next design philosophy, which is: contributors have to periodically re-run git-webkit setup to get some features. That doesn't seem overly burdensome to me, although I'd like to hear other's input.
 @alancoon

Member
Author
alancoon commented 1 minute ago
Deciding to close this because 1) what I hope to achieve through this PR can easily be achieved via other means of communication and 2) Jonathan's concern about custom prepare-commit-msg scripts.