Bug 242876

Summary:	[ews-build.webkit.org] Formally block PRs when ValidateSquashed fails
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Jonathan Bedard

Reported 2022-07-18 17:29:00 PDT

Right now, ValidateSquashed does not modify PRs or bugs when it fails. This makes it difficult for contributors to understand why their change was not landed. We should use our steps which modify commit-queue flags, merge-queue labels and comment on bugs/PRs to make it more clear to contributors why their change was not landed.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-07-18 17:29:41 PDT

<rdar://problem/97229223>

Jonathan Bedard

Comment 2 2022-07-18 17:33:22 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2530

EWS

Comment 3 2022-07-19 06:48:33 PDT

Committed 252597@main (4dfcc954e076): <https://commits.webkit.org/252597@main> Reviewed commits have been landed. Closing PR #2530 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.