Bug 242860

Summary: REGRESSION(252540@main): [ macOS ] 4X TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly (API tests) are constantly failing
Product: WebKit Reporter: Hercules Hjalmarsson <hhjalmarsson>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: bfulgham, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Hercules Hjalmarsson 2022-07-18 08:51:13 PDT
TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly1
TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly2
TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly3
TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly4

Are 4 constantly failing API tests on macOS since 252540@main.

HISTORY:
https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly1&test=TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly2&test=TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly3&test=TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly4

DIFF:
        
        /Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8159
        Expected equality of these values:
          pid1
            Which is: 95725
          pid2
            Which is: 95728
        
        
        /Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8161
        Value of: isJITEnabled(webView.get())
          Actual: false
        Expected: true
        
           
        /Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8172
        Value of: webViewConfiguration.get().defaultWebpagePreferences.-ModeEnabled
          Actual: false
        Expected: true
        
        
        /Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8201
        Value of: finishedNavigation
          Actual: true
        Expected: false


        /Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:8278
        Value of: preferences.-ModeEnabled
          Actual: false
        Expected: true

DIFF URL:
https://ews-build.webkit.org/#/builders/3/builds/76571/steps/14/logs/stdio
Comment 1 Radar WebKit Bug Importer 2022-07-18 08:51:54 PDT
<rdar://problem/97200346>
Comment 2 Hercules Hjalmarsson 2022-07-18 09:06:42 PDT
Test failure(s) are happening on macOS ToT. Bisected test regression to 252540@main by running command:

run-api-tests TestWebKitAPI.ProcessSwap.CaptivePortalModeSystemSettingChangeDoesNotReloadViewsWhenModeIsSetExplicitly(1-4)
Comment 3 Brent Fulgham 2022-07-18 09:28:30 PDT
Since these tests are passing on iOS Simulator, I'll bet I got a compile guard wrong somewhere.

I'm building for macOS to debug, and should have a fix shortly.
Comment 4 Brent Fulgham 2022-07-18 13:25:53 PDT
Forward-duping to Bug 242867 because I accidentally generated it while making a pull request.

*** This bug has been marked as a duplicate of bug 242867 ***