Bug 242836

Summary:	git-webkit upload should warn & confirm when overriding unrelated bug's PR
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	ap, jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Description Ryosuke Niwa 2022-07-16 12:19:50 PDT

I've had too many instances where my working tree on a "wrong" branch and it ended up overriding another bug's PR.
git-webkit should detect this and confirm with the user instead of going ahead & pushing PR to the remote.

Comment 1 Ryosuke Niwa 2022-07-16 12:20:48 PDT

e.g. see https://github.com/WebKit/WebKit/pull/2486 where I accidentally pushed PR for the bug 198280.

This is really annoying because then I'd have to restore the old branch and force push again in addition to creating a new branch for the bug.

Comment 2 Radar WebKit Bug Importer 2022-07-23 12:20:19 PDT

<rdar://problem/97489503>

Comment 3 Jonathan Bedard 2023-09-15 11:01:02 PDT

This was fixed in https://bugs.webkit.org/show_bug.cgi?id=244660, a few related changes in the same area have further cleaned up the behavior of that original change.

Comment 4 Jonathan Bedard 2023-09-15 11:01:10 PDT


*** This bug has been marked as a duplicate of bug 244660 ***