Bug 242833

Summary:	[LBSE] Enable compositing support for SVG elements
Product:	WebKit	Reporter:	Nikolas Zimmermann <zimmermann>
Component:	SVG	Assignee:	Nikolas Zimmermann <zimmermann>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	Hironori.Fujii, rbuis, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	241762
Bug Blocks:	27684, 90738, 243417

Description Nikolas Zimmermann 2022-07-16 06:07:27 PDT

Finally enable compositing, 3d-transforms, etc. for SVG.
All the preparatory work is done and LBSE has enough functionality to support it.

Comment 1 Nikolas Zimmermann 2022-07-16 08:38:31 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2487

Comment 2 Radar WebKit Bug Importer 2022-07-23 06:08:14 PDT

<rdar://problem/97481962>

Comment 3 EWS 2022-08-02 14:38:15 PDT

Committed 253054@main (5c46074bb656): <https://commits.webkit.org/253054@main>

Reviewed commits have been landed. Closing PR #2487 and removing active labels.

Comment 4 Fujii Hironori 2022-08-02 17:15:12 PDT

Hi, I tested 253054@main. But, your tiger doesn't animate. Is this expected? https://ibb.co/mcSnFZP

Comment 5 Nikolas Zimmermann 2022-08-03 00:19:01 PDT

(In reply to Fujii Hironori from comment #4)
> Hi, I tested 253054@main. But, your tiger doesn't animate. Is this expected?
> https://ibb.co/mcSnFZP
Thanks Fujji for the early testing. Yes it is expected -- there's still stuff missing to make the demos work. I will let you know when you can repeat the testing :-)

Comment 6 Nikolas Zimmermann 2022-08-03 00:26:07 PDT

(In reply to Nikolas Zimmermann from comment #5)
> (In reply to Fujii Hironori from comment #4)
> > Hi, I tested 253054@main. But, your tiger doesn't animate. Is this expected?
> > https://ibb.co/mcSnFZP
> Thanks Fujji for the early testing. Yes it is expected -- there's still
> stuff missing to make the demos work. I will let you know when you can
> repeat the testing :-)

Oh, I mixed this up, thought you were talking about the vibrant tiger example. The one from 2019 in the reveal.js presentation should work -- did you click on "Welcome to the future" to trigger the animation?

NOTE: You'll notice that the tiger SVG is clipped -- that's a bug in the actual html/svg file, due to missing viewport clipping in earlier LBSE versions. To see the unclipped tiger, you need to manually enlarge the viewport in the svg document fragment.

Comment 7 Fujii Hironori 2022-08-03 01:05:09 PDT

Oh, I didn't click. It works! You did a great job!

Comment 8 Nikolas Zimmermann 2022-08-03 04:33:57 PDT

(In reply to Fujii Hironori from comment #7)
> Oh, I didn't click. It works! You did a great job!

Thanks Fujii, still LBSE is not ready yet for production. I will soon create GitHub issues on https://github.com/nikolaszimmermann/WebKitIgalia/issues, to track what's still missing in LBSE -- better than tickin' off items on my personal, invisible TODO list :-)