| Summary: | REGRESSION(252070@main): [ iOS16 Debug ] Updates to WebCore::RenderLayerBacking::updateGeometry cause testing to exit early and not complete | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Robert Jenner <jenner> |
| Component: | New Bugs | Assignee: | Robert Jenner <jenner> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | darin, Hironori.Fujii, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=242209 https://bugs.webkit.org/show_bug.cgi?id=242884 |
||
|
Description
Robert Jenner
2022-07-15 23:06:06 PDT
I reverted 252070@main locally and then manually triggered a test build locally. Doing so resolved the issue, and the crash no longer occurred. Pull request: https://github.com/WebKit/WebKit/pull/2484 https://github.com/WebKit/WebKit/blob/cdb0c4a68794035df705609ca0ec8c7fb373091b/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm#L188 > ASSERT(m_isWaitingForDidUpdateGeometry); Did this assertion failed? bug#237557 also reported the assertion failure. I think this is a latent bug. And, your PR has a problem. It will create an unnecessary clipping mask layer. (In reply to Fujii Hironori from comment #4) > https://github.com/WebKit/WebKit/blob/ > cdb0c4a68794035df705609ca0ec8c7fb373091b/Source/WebKit/UIProcess/ > RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm#L188 > > > ASSERT(m_isWaitingForDidUpdateGeometry); > > Did this assertion failed? > > bug#237557 also reported the assertion failure. I think this is a latent bug. > > And, your PR has a problem. It will create an unnecessary clipping mask > layer. I'm not certain if it's the same reported assertion failure. I think this is the assertion that I am seeing with it. But I'm uncertain if it's the same: void RemoteLayerTreeDrawingAreaProxy::didUpdateGeometry() { ASSERT(m_isWaitingForDidUpdateGeometry); m_isWaitingForDidUpdateGeometry = false; // If the WKView was resized while we were waiting for a DidUpdateGeometry reply from the web process, // we need to resend the new size here. if (m_lastSentSize != m_size) sendUpdateGeometry(); } It is interesting that the test just before the assertion is `compositing/clipping/border-radius-async-overflow-clipping-layer.html` I filed bug 242884 on the assertion. It's unrelated. The test run stopping appears to be caused by ImageDiff crashing, possible a config issue. This turned out to be an issue where the bundle being tested had a copy of ImageDiff built for the iOS simulator, so tried to run that and it failed. |