Bug 242783

Summary:	Validate array sizes in WebGLRenderingContextBase::initializeNewContext
Product:	WebKit	Reporter:	Dan Glastonbury <djg>
Component:	WebGL	Assignee:	Dan Glastonbury <djg>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dino, kbr, kkinnunen, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Dan Glastonbury

Reported 2022-07-14 19:01:13 PDT

Some arrays have minimum sizes specified by the OpenGL ES spec and should never be zero. GL_COMBINED_TEXTURE_IMAGE_UNITS and GL_MAX_VERTEX_ATTRIBS have minimum values and should never be 0. When initialising a new context, if these values are 0 that indicates a problem with the GL context. The context is marked as lost to stop further commands from being processed.

Attachments
Add attachment proposed patch, testcase, etc.

Dan Glastonbury

Comment 1 2022-07-14 19:02:08 PDT

rdar://96709463

Dan Glastonbury

Comment 2 2022-07-14 19:08:25 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2439

EWS

Comment 3 2022-07-14 20:34:10 PDT

Committed 252488@main (c277889e5b21): <https://commits.webkit.org/252488@main> Reviewed commits have been landed. Closing PR #2439 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.