Bug 242757

Summary:	JavaScriptCore source files are missing includes when compiling them in a non-unified build
Product:	WebKit	Reporter:	Argyrios Kyrtzidis <akyrtzi>
Component:	JavaScriptCore	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Trivial	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Argyrios Kyrtzidis 2022-07-14 10:52:29 PDT

Due to unified sources bundling there are implicit dependencies between implementation files and if the files get compiled on their own it leads to compiler or linker errors, due to missing includes.

It would be good to add the missing includes so they can compile on their own, which is beneficial even for the unified build because adding/removing files changes the unified source partitions and can expose these errors later on.

Comment 1 Argyrios Kyrtzidis 2022-07-14 11:06:10 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2419

Comment 2 Radar WebKit Bug Importer 2022-07-21 10:53:14 PDT

<rdar://problem/97389174>

Comment 3 EWS 2022-09-27 10:43:48 PDT

Committed 254924@main (01ab6c22fca2): <https://commits.webkit.org/254924@main>

Reviewed commits have been landed. Closing PR #2419 and removing active labels.