Bug 242735

Summary: Commit queue fails to land patch with changes to prepare-ChangeLog script
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer, youssefdevelops
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237581, 246323    
Attachments:
Description Flags
Patch without test for EWS
none
Patch v2
none
Patch v3
jbedard: review+, ddkilzer: commit-queue-
Patch for landing none

Description David Kilzer (:ddkilzer) 2022-07-13 20:13:06 PDT 
Commit queue fails to land patch with changes to prepare-ChangeLog script.

See Bug 237581, Attachment 460877 [details]:
<https://bugs.webkit.org/show_bug.cgi?id=237581>

Specifically this failure:
<https://ews-build.webkit.org/#/builders/28/builds/22797>
Comment 1 David Kilzer (:ddkilzer) 2022-07-14 09:16:51 PDT 
Created attachment 460893 [details]
Patch without test for EWS
Comment 2 David Kilzer (:ddkilzer) 2022-07-15 14:08:18 PDT 
Created attachment 460934 [details]
Patch v2

Added test for the fix.  Also refactored existing tests to pull out common code.
Comment 3 David Kilzer (:ddkilzer) 2022-07-15 14:38:37 PDT 
Created attachment 460935 [details]
Patch v3
Comment 4 David Kilzer (:ddkilzer) 2022-07-15 14:42:46 PDT 
Comment on attachment 460935 [details]
Patch v3

New test passes!  Now up for review.
Comment 5 David Kilzer (:ddkilzer) 2022-07-15 14:49:45 PDT 
Comment on attachment 460935 [details]
Patch v3

Adding cq+ since all "services" tests passed.

I don't think this change even affects any other tests until it's deployed.
Comment 6 David Kilzer (:ddkilzer) 2022-07-15 16:57:09 PDT 
Created attachment 460944 [details]
Patch for landing
Comment 7 David Kilzer (:ddkilzer) 2022-07-15 16:57:57 PDT 
Comment on attachment 460944 [details]
Patch for landing

Tweaked the commit log message--not sure why these comments got lost.
Comment 8 EWS 2022-07-15 19:19:49 PDT 
Committed 252532@main (97dcaeae0581): <https://commits.webkit.org/252532@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460944 [details].
Comment 9 Radar WebKit Bug Importer 2022-07-15 19:20:19 PDT 
<rdar://problem/97106200>
Comment 10 David Kilzer (:ddkilzer) 2022-07-16 09:44:39 PDT 
This patch left the commit queue bubble in a weird state--the patch landed, but commit queue thought it didn't?!  Oh well.
Comment 11 Jonathan Bedard 2022-07-18 11:32:10 PDT 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/2515
Comment 12 EWS 2022-07-18 11:39:13 PDT 
Committed 252571@main (da71edd76bae): <https://commits.webkit.org/252571@main>

Reviewed commits have been landed. Closing PR #2515 and removing active labels.