Bug 242710

Summary: [CMake] Wrong message about dependency between introspection and gi-docgen
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: lisiwei
Status: RESOLVED FIXED    
Severity: Minor CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Linux   

Description Adrian Perez 2022-07-13 12:53:31 PDT
In Source/cmake/OptionsWPE.cmake (and OptionsWPE.cmake) we have the following:

  find_package(GIDocgen)
  if (ENABLE_DOCUMENTATION AND NOT GIDocgen_FOUND)
      message(FATAL_ERROR "gi-docgen is needed for ENABLE_INTROSPECTION.")
  endif ()

when in reality the dependency is the other way around: introspection is needed
for the gi-docgen documentation generator.
Comment 1 lisiwei 2022-07-15 14:46:45 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2472
Comment 2 EWS 2022-07-16 05:51:54 PDT
Committed 252538@main (85864ba4b069): <https://commits.webkit.org/252538@main>

Reviewed commits have been landed. Closing PR #2472 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-16 05:52:16 PDT
<rdar://problem/97121238>