Bug 242681

Summary: Adopt kCMSampleBufferAttachmentKey_FillDiscontinuitiesWithSilence
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   

Description Jean-Yves Avenard [:jya] 2022-07-13 02:38:49 PDT 
Test case:
https://jyavenard.github.io/htmltests/tests/mse_webm/83910012/

In this sample, we have a 1ms audio discontinuity appearing at t=20ms however due to an implementation detail can be heard at t=2s.

In bug 234458, we applied a workaround so that the silence is inserted right when the discontinuity is occurring, which makes it less audible.

The audio dropout is due to the audio layer inserting silence when a gap is encountered ; however there's no real gap in the audio content, just that the timestamp in the container are nonsensical.

By adopting the key kCMSampleBufferAttachmentKey_FillDiscontinuitiesWithSilence we could tell the audio layer to not insert those silences.
Comment 1 Jean-Yves Avenard [:jya] 2022-07-13 02:39:05 PDT 
rdar://83910012
Comment 2 Jean-Yves Avenard [:jya] 2022-07-13 02:45:50 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/2359
Comment 3 EWS 2022-07-17 23:20:15 PDT 
Committed 252561@main (144b9069f26b): <https://commits.webkit.org/252561@main>

Reviewed commits have been landed. Closing PR #2359 and removing active labels.