Bug 242661

Summary:	Remove executable bit from source files
Product:	WebKit	Reporter:	Michael Catanzaro <mcatanzaro>
Component:	CSS	Assignee:	Michael Catanzaro <mcatanzaro>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	PC
OS:	All

Michael Catanzaro

Reported 2022-07-12 15:26:09 PDT

Sometimes we make C++ source files executable by mistake: *** WARNING: ./usr/src/debug/webkit2gtk3-2.37.1-1.fc37.x86_64/Source/WebCore/rendering/style/StyleCursorImage.cpp is executable but has no shebang, removing executable bit *** WARNING: ./usr/src/debug/webkit2gtk3-2.37.1-1.fc37.x86_64/Source/WebCore/rendering/style/StyleCursorImage.h is executable but has no shebang, removing executable bit *** WARNING: ./usr/src/debug/webkit2gtk3-2.37.1-1.fc37.x86_64/Source/WebCore/rendering/style/StyleImageSet.cpp is executable but has no shebang, removing executable bit *** WARNING: ./usr/src/debug/webkit2gtk3-2.37.1-1.fc37.x86_64/Source/WebCore/rendering/style/StyleImageSet.h is executable but has no shebang, removing executable bit *** WARNING: ./usr/src/debug/webkit2gtk3-2.37.1-1.fc37.x86_64/Source/WebCore/rendering/style/StyleMultiImage.cpp is executable but has no shebang, removing executable bit *** WARNING: ./usr/src/debug/webkit2gtk3-2.37.1-1.fc37.x86_64/Source/WebCore/rendering/style/StyleMultiImage.h is executable but has no shebang, removing executable bit

Attachments
Add attachment proposed patch, testcase, etc.

Michael Catanzaro

Comment 1 2022-07-12 15:27:49 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2347

EWS

Comment 2 2022-07-12 16:07:37 PDT

Committed 252397@main (482ec92c268d): <https://commits.webkit.org/252397@main> Reviewed commits have been landed. Closing PR #2347 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-07-12 16:08:16 PDT

<rdar://problem/96915945>

Note You need to log in before you can comment on or make changes to this bug.