Bug 242616
| Summary: | [Make] Update build-jsc and build-webgpu to use workspace builds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
We default to workspace build for build-webkit since https://commits.webkit.org/251501@main. We should do the same for build-jsc and build-webgpu, which are the two users of `BuildSubproject.pm` logic that calls into Make.
This does not strictly need to be done before switching all Make-based builds to default to workspace mode. However, doing this first means that:
1) We'll override the default workspace behavior to ensure that `build-jsc` and friends always use the open-source WebKit.xcworkspace
2) We avoid redundant `make` invocations once Make switches to workspace mode by default
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/2312
Radar WebKit Bug Importer
<rdar://problem/97227552>
EWS
Committed 252809@main (03af7beefb55): <https://commits.webkit.org/252809@main>
Reviewed commits have been landed. Closing PR #2312 and removing active labels.
Elliott Williams
Re-opening for pull request https://github.com/WebKit/WebKit/pull/2770
EWS
Committed 252861@main (2fe47ad4362f): <https://commits.webkit.org/252861@main>
Reviewed commits have been landed. Closing PR #2770 and removing active labels.