Bug 242611
| Summary: | Document::shouldMaskURLForBindings and Element::getAttributeForBindings have various issues | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> |
| Component: | WebCore Misc. | Assignee: | Timothy Hatcher <timothy> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Timothy Hatcher
1) Document::shouldMaskURLForBindings should return false if the document's URL is the same as the URL being checked. It does not make sense to mask these, since they are from the same protocol (and it can break scripts that rely on these URLs being unmasked).
2) Element::getAttributeForBindings is always passing the attribute value to completeURLsInAttributeValue(). However, we only need to do this for URL attributes, by checking isURLAttribute(). This caused a large performance regression on Speedometer's AngularJS-TodoMVC and some other subtests that are attribute heavy.
rdar://81991245
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Timothy Hatcher
Pull request: https://github.com/WebKit/WebKit/pull/2309
EWS
Committed 252418@main (eec128ed1111): <https://commits.webkit.org/252418@main>
Reviewed commits have been landed. Closing PR #2309 and removing active labels.