Bug 242536

Summary:	[git-webkit] Allow for re-running pre-pr checks
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	annevk, ap, jbedard, ryanhaddad, simon.fraser, webkit-bug-importer, y_soliman
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Description Simon Fraser (smfr) 2022-07-08 14:18:20 PDT

`webkit-patch upload` would let me fix style issues locally, when the style checker found them, while the command is running and without having to cancel and re-run the command.

`git webkit pr` doesn't seem to have this same feature, making it more cumbersome to fix style errors.

Comment 1 Radar WebKit Bug Importer 2022-07-15 14:19:15 PDT

<rdar://problem/97093963>

Comment 2 Simon Fraser (smfr) 2022-10-11 21:31:24 PDT

This is one my top `git webkit` annoyances, and shouldn't be hard to fix.

Comment 3 Anne van Kesteren 2023-07-07 16:22:11 PDT

I think an intermediate fix where you have to re-run the command but it at least hasn't side-effected would already be a major improvement.

A big part of the problem here is that it creates a branch and then finds a style error and at that point you can no longer run the same command as you're on a branch.

Comment 4 Jonathan Bedard 2023-07-10 07:43:50 PDT

Pull request: https://github.com/WebKit/WebKit/pull/15694

Comment 5 EWS 2023-10-31 07:21:49 PDT

Committed 270007@main (052c4c37d40f): <https://commits.webkit.org/270007@main>

Reviewed commits have been landed. Closing PR #15694 and removing active labels.

Comment 6 EWS 2023-10-31 10:29:01 PDT

Committed 267815.489@safari-7617-branch (b7a0e360e4b6): <https://commits.webkit.org/267815.489@safari-7617-branch>

Reviewed commits have been landed. Closing PR #904 and removing active labels.