Bug 242498

Summary:	changing mask or filter property between two URLs on SVG element doesn't cause an update
Product:	WebKit	Reporter:	Cameron McCormack (:heycam) <heycam>
Component:	SVG	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	ahmad.saleem792, baba, karlcow, sabouhallawa, tanaka.toshiyuki, webkit-bug-importer, zimmermann
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Cameron McCormack (:heycam) 2022-07-07 23:49:27 PDT

Caught by the tests I'm adding in bug 242497.

Comment 1 Radar WebKit Bug Importer 2022-07-14 23:50:17 PDT

<rdar://problem/97058470>

Comment 2 Said Abou-Hallawa 2022-07-15 12:40:53 PDT

Can you please attach a test case?

Comment 3 Said Abou-Hallawa 2022-07-15 14:41:52 PDT

This will be fixed in the cocoa underlying frameworks.

Comment 4 Said Abou-Hallawa 2022-07-15 14:43:10 PDT

Sorry I meant another bug to be closed.

Comment 5 Cameron McCormack (:heycam) 2022-07-15 18:19:23 PDT

(In reply to Said Abou-Hallawa from comment #2)
> Can you please attach a test case?

The expected-fail LayoutTests/svg/resource-invalidation/mask-resource-invalidation.html and LayoutTests/svg/resource-invalidation/filter-resource-invalidation.html tests that I landed test this.

I have upcoming patches for lazy filter and mask resource invalidation that I'll upload soon.  The filter one fixes the filter invalidation issue, but the mask one doesn't.  I haven't looked into why that is yet.

Comment 6 Takao Baba 2022-10-07 02:45:38 PDT

I'm not completely sure whether this is the same issue or new one, but there is a regression about this SVG filter issue on Safari 16.

Steps to reproduce:
Open https://jsbin.com/riyawenudu/edit?html,output

Expected behavior:
The rectangle color will be changed every second (red -> green -> blue -> red ...).

Actual behavior:
On safari 16 (both macOS and iOS), the color won't be changed.

I cannot create reduced testcase without using React.

Comment 7 Cameron McCormack (:heycam) 2022-10-21 15:52:45 PDT

(In reply to Takao Baba from comment #6)
> I'm not completely sure whether this is the same issue or new one, but there
> is a regression about this SVG filter issue on Safari 16.
> 
> Steps to reproduce:
> Open https://jsbin.com/riyawenudu/edit?html,output

Thanks for reporting this issue with feComponentTransfer.  It's being fixed in bug 246602.

Comment 8 Cameron McCormack (:heycam) 2022-11-02 23:52:29 PDT

Fixing the filter case in bug 247411.

Comment 9 Karl Dubost 2024-05-28 02:38:20 PDT

This seems to be working for me on a recent build of Safari.

Comment 10 Ahmad Saleem 2024-05-28 02:39:55 PDT

It is not reproducible on Safari Technology Preview 195 on Sonoma using test case from Comment 06 and it updates correctly each second to different color.

Marking this as 'Configuration Changed', if it is still reproducing, please reopen with newer test case.