Bug 242440

Summary: [ews] status url results in 500 for unknown patch id
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=242442
Bug Depends on:    
Bug Blocks: 240680    

Description Aakash Jain 2022-07-07 07:08:25 PDT
On ews.webkit.org status url results in 500 for unknown patch id. 
e.g.: https://ews.webkit.org/status/1112121212121212/ results in 500 with following error in logs:

==> ews.log <==
2022-07-07 14:07:36,305 - Internal Server Error: /status/123456789/
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 68, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/django/views/generic/base.py", line 88, in dispatch
    return handler(request, *args, **kwargs)
  File "/var/ews/OpenSource/Tools/CISupport/ews-app/ews/views/status.py", line 67, in get
    return JsonResponse(response_data)
  File "/usr/lib/python2.7/site-packages/django/http/response.py", line 524, in __init__
    'In order to allow non-dict objects to be serialized set the '
TypeError: In order to allow non-dict objects to be serialized set the safe parameter to False.
Comment 1 Aakash Jain 2022-07-07 07:19:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2167
Comment 2 EWS 2022-07-07 07:49:51 PDT
Committed 252213@main (2f47d87846dc): <https://commits.webkit.org/252213@main>

Reviewed commits have been landed. Closing PR #2167 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-07 07:50:18 PDT
<rdar://problem/96597188>