Bug 242418

Summary: REGRESSION (r221177): Redundant icon fetching in the web process for file inputs
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: FormsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Simon Fraser (smfr) 2022-07-06 20:14:33 PDT
In r221177 there was an inadvertent switching from `icon ? RequestIcon::No : RequestIcon::Yes` to `icon ? RequestIcon::Yes : RequestIcon::No` in what is now FileInputType::didCreateFileList(), which results in a redundant fetch of the file icon in the web process when the UI process already did this and supplied the icon.
Comment 1 Simon Fraser (smfr) 2022-07-06 20:19:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2148
Comment 2 EWS 2022-07-07 08:34:50 PDT
Committed 252215@main (b58cec34fd85): <https://commits.webkit.org/252215@main>

Reviewed commits have been landed. Closing PR #2148 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-07-07 08:35:16 PDT
<rdar://problem/96599764>