| Summary: | [Media] Destroy media player on fatal playback error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Enrique Ocaña <eocanha> |
| Component: | Media | Assignee: | Enrique Ocaña <eocanha> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | philn, rackler, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Enrique Ocaña
2022-07-06 09:37:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2122 Committed 253522@main (1c9cc6e485dc): <https://commits.webkit.org/253522@main> Reviewed commits have been landed. Closing PR #2122 and removing active labels. Revert "[Media] Destroy media player on fatal playback error" This reverts because causing three imported/w3c/web-platform-tests/media-source/mediasource-changetype tests are a consistent crash. Committed 253621@main (a44a944): https://commits.webkit.org/253621@main Verified Revert "[Media] Destroy media player on fatal playback error" at 253621@main; tests are no longer crashing on macOS Debug. When reverting a patch please reopen the corresponding bug. As the original crash was fixed in https://github.com/WebKit/WebKit/commit/45759ff (see also https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/880) and this https://github.com/WebKit/WebKit/pull/2122 was just preventive (the issue can't actually be reproduced upstream), I'm not going to insist about fixing the issue here. If it's ever reproduced in the future, we can reopen the bug again. Closing as wontfix. |