Bug 242301

Summary:	Rename offlineasm's asm.deferAction to asm.deferOSDarwinAction.
Product:	WebKit	Reporter:	Mark Lam <mark.lam>
Component:	JavaScriptCore	Assignee:	Mark Lam <mark.lam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Mark Lam

Reported 2022-07-03 18:43:06 PDT

Similarly, rename the underlying field from @deferredAction to @deferredOSDarwinAction. This deferAction was only used for OS(DARWIN) anyway. By changing it to be OS(DARWIN) specific to indicate its actual usage, we can make the generated LLIntAssembly.h more readable and efficient. Previously, we emit this code: OFFLINE_ASM_GLOBAL_LABEL(llintPCRangeEnd) #if OS(DARWIN) ".loh AdrpLdrGot Ljsc_llint_loh_adrp_1, Ljsc_llint_loh_ldr_1 \n" #endif #if OS(DARWIN) ".loh AdrpLdrGot Ljsc_llint_loh_adrp_2, Ljsc_llint_loh_ldr_2 \n" #endif ... #if OS(DARWIN) ".loh AdrpLdrGot Ljsc_llint_loh_adrp_2308, Ljsc_llint_loh_ldr_2308 \n" #endif OFFLINE_ASM_END Now, we emit this instead: OFFLINE_ASM_GLOBAL_LABEL(llintPCRangeEnd) #if OS(DARWIN) ".loh AdrpLdrGot Ljsc_llint_loh_adrp_1, Ljsc_llint_loh_ldr_1 \n" ".loh AdrpLdrGot Ljsc_llint_loh_adrp_2, Ljsc_llint_loh_ldr_2 \n" ... ".loh AdrpLdrGot Ljsc_llint_loh_adrp_2308, Ljsc_llint_loh_ldr_2308 \n" #endif // OS(DARWIN) OFFLINE_ASM_END

Attachments
Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2022-07-03 18:58:52 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2046

EWS

Comment 2 2022-07-03 22:21:36 PDT

Committed 252109@main (816faa4c6073): <https://commits.webkit.org/252109@main> Reviewed commits have been landed. Closing PR #2046 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-07-03 22:22:13 PDT

<rdar://problem/96379859>

Note You need to log in before you can comment on or make changes to this bug.