Bug 242258
| Summary: | [Make] Recognize feature flags in BUILD_WEBKIT_OPTIONS | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
build-webkit recognizes features defined in FeatureList.pm and passes corresponding build settings to Xcode. Make, despite having a BUILD_WEBKIT_OPTIONS setting for developers to override, does not parse out feature flag arguments. As a result, if you want to pass a feature flag to Make, you have to know what the corresponding build setting is. You also need to know that build-webkit defines the build setting as own name (i.e. ENABLE_PDFJS=ENABLE_PDFJS) and not YES.
We should fix this so that
build-webkit --debug --pdfjs
and
make debug BUILD_WEBKIT_OPTIONS=--pdfjs
pass the same settings.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/2004
EWS
Committed 252082@main (97a065060b7d): <https://commits.webkit.org/252082@main>
Reviewed commits have been landed. Closing PR #2004 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/96324453>