Bug 242252

Summary:	GitHub links are broken in Bugzilla patch review
Product:	WebKit	Reporter:	Alexey Proskuryakov <ap>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	jbedard, mitz, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Description Alexey Proskuryakov 2022-07-01 09:23:46 PDT

GitHub links in patch review go to URLs like https://github.com/WebKit/WebKit/blob/%7Bfilename%7D#L2570

Steps to reproduce:
1. Open any new patch for review, e.g. https://bugs.webkit.org/attachment.cgi?id=460612&action=review
2. Click on file name, e.g. "Source/WebCore/css/CSSComputedStyleDeclaration.cpp"

Results: GitHub 404 page, the URL is obviously wrong.

Comment 1 Radar WebKit Bug Importer 2022-07-08 09:24:12 PDT

<rdar://problem/96676738>

Comment 2 Alexey Proskuryakov 2022-09-06 17:33:53 PDT

*** Bug 244857 has been marked as a duplicate of this bug. ***

Comment 3 Jonathan Bedard 2023-01-05 16:30:08 PST

Pull request: https://github.com/WebKit/WebKit/pull/8263

Comment 4 EWS 2023-01-06 07:22:26 PST

Committed 258540@main (cc9e0d6d9154): <https://commits.webkit.org/258540@main>

Reviewed commits have been landed. Closing PR #8263 and removing active labels.