Bug 242217

Summary: [WPE][GTK] web process leak if webkit_download_set_destination is called with empty destination
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: WebKit2Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: dpino, kkinnunen, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 241583    

Description Yury Semikhatsky 2022-06-30 16:45:22 PDT 
Passing empty string as the destination according to the current logic in NetworkProcess::findPendingDownloadLocation[1] should cancel the download. In practice the download never finishes and if the browser stays open for > 30s after the page is closed corresponding web process may leak similar to https://bugs.webkit.org/show_bug.cgi?id=241583 (I didn't debug the exact retention path).


[1] https://github.com/WebKit/WebKit/blob/fcd1d36de2ca84f2d8736165fbc08cd6251f9578/Source/WebKit/NetworkProcess/NetworkProcess.cpp#L2042-L2043
Comment 1 Yury Semikhatsky 2022-06-30 16:55:24 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/1970
Comment 2 EWS 2022-11-16 09:00:20 PST 
Committed 256737@main (c985acc37157): <https://commits.webkit.org/256737@main>

Reviewed commits have been landed. Closing PR #1970 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2022-11-16 09:01:23 PST 
<rdar://problem/102422549>