| Summary: | Simplify resolveForDocument | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||
| Component: | CSS | Assignee: | Rob Buis <rbuis> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Safari 15 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Rob Buis
2022-06-30 05:57:28 PDT
Created attachment 460577 [details]
Patch
Comment on attachment 460577 [details]
Patch
Where is the explanation for why this code can be removed? Why was the code there in the first place? Why does it turn out to not be needed? It’s great that all the tests pass, so I am guessing this code is truly unnecessary, but how did you determine that? Are you sure this isn’t just due to a missing test case?
Created attachment 460635 [details]
Patch
Created attachment 460641 [details]
Patch
(In reply to Darin Adler from comment #2) > Comment on attachment 460577 [details] > Patch > > Where is the explanation for why this code can be removed? Why was the code > there in the first place? Why does it turn out to not be needed? It’s great > that all the tests pass, so I am guessing this code is truly unnecessary, > but how did you determine that? Are you sure this isn’t just due to a > missing test case? I found this out just by code inspection. I checked all getters and setters between the two FontCascadeDescription usages but they do not depend on it, so the change should be safe. Committed 252111@main (d2b5507f6b8e): <https://commits.webkit.org/252111@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460641 [details]. |