Bug 242181

Summary: Simplify resolveForDocument
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 15   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2022-06-30 05:57:28 PDT
Simplify resolveForDocument.
Attachments
Patch (1.48 KB, patch)
2022-06-30 06:07 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (3.08 KB, patch)
2022-07-02 12:42 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (3.23 KB, patch)
2022-07-03 11:29 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2022-06-30 06:07:13 PDT
Created attachment 460577 [details] Patch
Darin Adler
Comment 2 2022-07-01 22:28:45 PDT
Comment on attachment 460577 [details] Patch Where is the explanation for why this code can be removed? Why was the code there in the first place? Why does it turn out to not be needed? It’s great that all the tests pass, so I am guessing this code is truly unnecessary, but how did you determine that? Are you sure this isn’t just due to a missing test case?
Rob Buis
Comment 3 2022-07-02 12:42:40 PDT
Created attachment 460635 [details] Patch
Rob Buis
Comment 4 2022-07-03 11:29:23 PDT
Created attachment 460641 [details] Patch
Rob Buis
Comment 5 2022-07-03 14:29:44 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 460577 [details] > Patch > > Where is the explanation for why this code can be removed? Why was the code > there in the first place? Why does it turn out to not be needed? It’s great > that all the tests pass, so I am guessing this code is truly unnecessary, > but how did you determine that? Are you sure this isn’t just due to a > missing test case? I found this out just by code inspection. I checked all getters and setters between the two FontCascadeDescription usages but they do not depend on it, so the change should be safe.
EWS
Comment 6 2022-07-04 00:44:56 PDT
Committed 252111@main (d2b5507f6b8e): <https://commits.webkit.org/252111@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460641 [details].
Radar WebKit Bug Importer
Comment 7 2022-07-04 00:45:14 PDT
<rdar://problem/96384588>
Note You need to log in before you can comment on or make changes to this bug.