| Summary: | [LFC][FFC] Add support for non-stretching flex items with flex-basis | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, ntim, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2022-06-29 09:34:17 PDT
Created attachment 460543 [details]
Patch
Comment on attachment 460543 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460543&action=review > Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:232 > + auto flexedSize = reolvedFlexItem.flexBasis + reolvedFlexItem.flexGrow * flexGrowBase; > + if (flexedSize && reolvedFlexItem.minimumSize >= flexedSize) { > + reolvedFlexItem.isFrozen = true; > didFreeze = true; > - totalGrowth -= stretchingFlex.flexGrow; > - totalFlexibleSpace -= stretchingFlex.flexBasis; > - availableSpace -= stretchingFlex.minimumSize; > + totalGrowth -= reolvedFlexItem.flexGrow; > + totalFlexibleSpace -= reolvedFlexItem.flexBasis; > + availableSpace -= reolvedFlexItem.minimumSize; > } typo: reolved Created attachment 460629 [details]
Patch
Committed 252087@main (02229f46cd9b): <https://commits.webkit.org/252087@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460629 [details]. |