Bug 242089

Summary:	[Make] Avoid passing default xcodebuild options to installsrc
Product:	WebKit	Reporter:	Elliott Williams <emw>
Component:	Tools / Tests	Assignee:	Elliott Williams <emw>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	ap, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Elliott Williams

Reported 2022-06-28 16:05:40 PDT

Our "standard" xcodebuild options, as computed by `XcodeOptionString()` in webkitdirs, are not suitable for `xcodebuild installsrc`. In particular, they can lead to PIFCache directories being created in WebKitBuild that are created as a side effect of installsrc.

Attachments
Add attachment proposed patch, testcase, etc.

Elliott Williams

Comment 1 2022-06-28 16:07:02 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1877

Elliott Williams

Comment 2 2022-06-28 16:08:02 PDT

rdar://95680722

EWS

Comment 3 2022-07-01 09:54:56 PDT

Committed 252050@main (c68a647dbadb): <https://commits.webkit.org/252050@main> Reviewed commits have been landed. Closing PR #1877 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.