Bug 242001

Summary: Remove GraphicsLayer::setMasksToBoundsRect
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: CompositingAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch none

Description Fujii Hironori 2022-06-25 06:00:25 PDT 
Remove GraphicsLayer::setMasksToBoundsRect

I don't know why GraphicsLayer::setMasksToBoundsRect is needed.
GraphicsLayer has the following similar desendants clipping methods.

 GraphicsLayer::setContentsClippingRect(const FloatRoundedRect& roundedRect)
 GraphicsLayer::setContentsRectClipsDescendants(bool b)
Comment 1 Fujii Hironori 2022-06-25 06:05:41 PDT 
Created attachment 460491 [details]
WIP patch
Comment 2 Simon Fraser (smfr) 2022-06-27 09:02:47 PDT 
setMasksToBoundsRect sets the rect used to clip descendant GraphicsLayers.

setContentsClippingRect sets the rect used to clip only this layer's content layer.
Comment 3 Simon Fraser (smfr) 2022-06-27 09:06:09 PDT 
Comment on attachment 460491 [details]
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=460491&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:-408
> -    m_masksToBoundsRect = roundedRect;

You don't remove the m_masksToBoundsRect member variable. If you do, you'll find that it's referenced in GraphicsLayerCA::updateMasksToBoundsRect().
Comment 4 Fujii Hironori 2022-06-27 12:56:25 PDT 
That's the reason why I used setContentsRectClipsDescendants together. I'm going to try to remove all related code. Thank you for the comment.
Comment 5 Fujii Hironori 2022-06-27 14:18:06 PDT 
Created attachment 460506 [details]
Patch
Comment 6 Fujii Hironori 2022-06-27 14:24:53 PDT 
Created attachment 460507 [details]
Patch
Comment 7 EWS 2022-06-28 13:08:19 PDT 
Committed 251923@main (2e43c7cbb61a): <https://commits.webkit.org/251923@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 460507 [details].
Comment 8 Radar WebKit Bug Importer 2022-06-28 13:09:16 PDT 
<rdar://problem/96085182>