Bug 242001

Summary: Remove GraphicsLayer::setMasksToBoundsRect
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: CompositingAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP patch
none
Patch
none
Patch none

Fujii Hironori
Reported 2022-06-25 06:00:25 PDT
Remove GraphicsLayer::setMasksToBoundsRect I don't know why GraphicsLayer::setMasksToBoundsRect is needed. GraphicsLayer has the following similar desendants clipping methods. GraphicsLayer::setContentsClippingRect(const FloatRoundedRect& roundedRect) GraphicsLayer::setContentsRectClipsDescendants(bool b)
Attachments
WIP patch (3.68 KB, patch)
2022-06-25 06:05 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (7.50 KB, patch)
2022-06-27 14:18 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (8.95 KB, patch)
2022-06-27 14:24 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-06-25 06:05:41 PDT
Created attachment 460491 [details] WIP patch
Simon Fraser (smfr)
Comment 2 2022-06-27 09:02:47 PDT
setMasksToBoundsRect sets the rect used to clip descendant GraphicsLayers. setContentsClippingRect sets the rect used to clip only this layer's content layer.
Simon Fraser (smfr)
Comment 3 2022-06-27 09:06:09 PDT
Comment on attachment 460491 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=460491&action=review > Source/WebCore/platform/graphics/GraphicsLayer.cpp:-408 > - m_masksToBoundsRect = roundedRect; You don't remove the m_masksToBoundsRect member variable. If you do, you'll find that it's referenced in GraphicsLayerCA::updateMasksToBoundsRect().
Fujii Hironori
Comment 4 2022-06-27 12:56:25 PDT
That's the reason why I used setContentsRectClipsDescendants together. I'm going to try to remove all related code. Thank you for the comment.
Fujii Hironori
Comment 5 2022-06-27 14:18:06 PDT
Created attachment 460506 [details] Patch
Fujii Hironori
Comment 6 2022-06-27 14:24:53 PDT
Created attachment 460507 [details] Patch
EWS
Comment 7 2022-06-28 13:08:19 PDT
Committed 251923@main (2e43c7cbb61a): <https://commits.webkit.org/251923@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460507 [details].
Radar WebKit Bug Importer
Comment 8 2022-06-28 13:09:16 PDT
<rdar://problem/96085182>
Note You need to log in before you can comment on or make changes to this bug.