| Summary: | Fix block-aspect-ratio-037.html | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||
| Component: | CSS | Assignee: | Rob Buis <rbuis> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | changseok, clopez, darin, esprehn+autocc, ews-watchlist, glenn, jochen.kuehner, kondapallykalyan, pdr, webkit-bug-importer, youennf, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Safari 15 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Rob Buis
2022-06-25 03:14:55 PDT
Created attachment 460490 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 460490 [details]
Patch
r=me
Is the single regression test sufficient coverage for both code changes?
Created attachment 460502 [details]
Patch
(In reply to Darin Adler from comment #3) > Comment on attachment 460490 [details] > Patch > > r=me > > Is the single regression test sufficient coverage for both code changes? The change in constrainLogicalHeightByMinMax is covered by aspect-ratio/grid-aspect-ratio-022.html. Committed 251908@main (e97db329a49a): <https://commits.webkit.org/251908@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460502 [details]. *** Bug 231775 has been marked as a duplicate of this bug. *** |