| Summary: | [GTK] Segfault in firstChild when clicking on a pull request on GitHub while logged in | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | antoyo <bouanto> |
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | aperez, Hironori.Fujii, iamleot+webkit-bugzilla, mcatanzaro, svillar, xry111 |
| Priority: | P3 | Keywords: | Gtk |
| Version: | WebKit Local Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=238429 | ||
|
Description
antoyo
2022-06-23 20:55:20 PDT
Epiphany version: Web 42.2 Webkit2gtk version: webkit2gtk-4.1 2.36.3-1 I'm seeing that too with WebKitGTK 2.36.3 on NetBSD (not 100% reproducible but happens very often). Possible interesting data point: this started only recently (less than 24 hours ago, i.e. probably since today (2022-06-24)) so I think that some github.com change started triggering that. *** Bug 242066 has been marked as a duplicate of this bug. *** I hit this constantly as well, seems weird that only GTK is affected. I've done a bisection to find the commit which fixed this issue, because it is not a problem anymore in ToT. After some churning, the patch from bug #238429 seems to fix this in my limited testing. I am doing now a release build with the patch applied on top of the 2.36 branch to use it for a few hours to be completely certain before closing this bug :) Wow, great catch! Thank you Adrian! Can we merge the patch for 2.36.6 then? (In reply to Xi Ruoyao from comment #7) > Can we merge the patch for 2.36.6 then? I have been testing a build with the patch applied (and additionally a related patch on top) and in half a day of continuous usage I have not hit any crashes in GitHub anymore. I have pushed both to the 2.36 release branch, so version 2.36.6 will have this resolved =) *** This bug has been marked as a duplicate of bug 238429 *** (In reply to Adrian Perez from comment #8) > (In reply to Xi Ruoyao from comment #7) > > Can we merge the patch for 2.36.6 then? > > I have been testing a build with the patch applied (and additionally > a related patch on top) and in half a day of continuous usage I have > not hit any crashes in GitHub anymore. I have pushed both to the 2.36 > release branch, so version 2.36.6 will have this resolved =) > > *** This bug has been marked as a duplicate of bug 238429 *** That's great! Thank you very much again Adrian for bisecting and backporting it! (In reply to Leonardo Taccari from comment #9) > (In reply to Adrian Perez from comment #8) > > (In reply to Xi Ruoyao from comment #7) > > > Can we merge the patch for 2.36.6 then? > > > > I have been testing a build with the patch applied (and additionally > > a related patch on top) and in half a day of continuous usage I have > > not hit any crashes in GitHub anymore. I have pushed both to the 2.36 > > release branch, so version 2.36.6 will have this resolved =) > > > > *** This bug has been marked as a duplicate of bug 238429 *** > > That's great! > > Thank you very much again Adrian for bisecting and backporting it! You're welcome! The new release that includes the fix has been published: https://webkitgtk.org/2022/08/07/webkitgtk2.36.6-released.html |