Bug 24177

Summary:

Full Page Zoom: Gmail gets horizontal scrollbar

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

colm, erik.arvidsson, tal.ayal.cohen

Priority:

Keywords:

GoogleBug

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Test case	none
Now works in IE standards mode.	none
standards mode test case (in Safari, this only works LOCALLY due to data: access permissions)	none
quirks mode test case (same as standards, minus the doctype. works in all browsers)	none
Patch for ojan/eseidel to try out	none
Testcase showing that getBoundingClientRect is not working correctly when zoomed	none

Ojan Vafai

Reported 2009-02-25 16:38:07 PST

cmd+ on gmail and you get a horizontal scrollbar. Each cmd+ makes the scrollWidth larger. This is probably some interaction between gmail's layout manager and the full page zoom. Same thing happens on Chrome and IE. However on Firefox you get a flash of a horizontal scrollbar, but then it resizes appropriately. Will also follow up with gmail engineers.

Attachments
Test case (950 bytes, text/html) 2009-03-03 15:59 PST, Ojan Vafai	no flags	Details
Now works in IE standards mode. (1.79 KB, text/html) 2009-03-03 16:39 PST, Ojan Vafai	no flags	Details
standards mode test case (in Safari, this only works LOCALLY due to data: access permissions) (1.84 KB, text/html) 2009-03-03 17:02 PST, Eric Seidel (no email)	no flags	Details
quirks mode test case (same as standards, minus the doctype. works in all browsers) (1.82 KB, text/html) 2009-03-03 17:03 PST, Eric Seidel (no email)	no flags	Details
Patch for ojan/eseidel to try out (1016 bytes, patch) 2009-03-03 17:52 PST, Dave Hyatt	no flags	Details Formatted Diff Diff
Testcase showing that getBoundingClientRect is not working correctly when zoomed (969 bytes, text/html) 2009-05-06 10:37 PDT, Erik Arvidsson	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ojan Vafai

Comment 1 2009-03-03 15:59:48 PST

Created attachment 28243 [details] Test case Test case to help debugging what different browsers do. Seems that FF and WebKit scale the metrics they return off document.body and document.documentElement, but they do so in inconsistent ways and differently for quirsk v standards mode and top-level document v iframe.

Ojan Vafai

Comment 2 2009-03-03 16:37:14 PST

FF Standards and Quirks: Scales BODY and HTML elements in the top-level document, but not in iframes. WebKit Standards: Scales the HTML in the iframe. Scales the BODY element in the top-level document. WebKit Quirks: Scales the BODY in the iframe. Scales the HTML element in the top-level document. IE Quirks: Only has metrics on the BODY and scales the BODY in the top-level document only. IE Standards: Doesn't scale anything.

Ojan Vafai

Comment 3 2009-03-03 16:39:11 PST

Created attachment 28245 [details] Now works in IE standards mode.

Dave Hyatt

Comment 4 2009-03-03 16:57:07 PST

The special cases of clientWidth and clientHeight in Element are not being adjusted for the document's zoom factor. That's likely the bug. I also noticed that all of the scrollLeft/Top/Width/Height getters and setters in HTMLBodyElement are not adjusting for full-page zoom either.

Eric Seidel (no email)

Comment 5 2009-03-03 17:02:52 PST

Created attachment 28247 [details] standards mode test case (in Safari, this only works LOCALLY due to data: access permissions)

Eric Seidel (no email)

Comment 6 2009-03-03 17:03:38 PST

Created attachment 28248 [details] quirks mode test case (same as standards, minus the doctype. works in all browsers)

Dave Hyatt

Comment 7 2009-03-03 17:52:16 PST

Created attachment 28251 [details] Patch for ojan/eseidel to try out

Ojan Vafai

Comment 8 2009-03-03 18:05:54 PST

With hyatt's patch, it fixes some of the Gmail/Reader bugs around scrollbars in FPZ. Hyatt pointed out on IRC that getBoundingClientRect doesn't take FPZ into account either. This likely is the remaining source of bugs for Gmail/Reader.

Ojan Vafai

Comment 9 2009-03-03 18:07:41 PST

Also, with hyatt's patch, WebKit now matches FF behavior in the attached tests cases for both quirks and standards modes.

Jon@Chromium

Comment 10 2009-03-19 14:24:56 PDT

Can we get this patch submitted? Where are we in the review process?

Colm Buckley

Comment 11 2009-04-17 05:54:51 PDT

Any commentary on this? Having a superfluous horizontal scrollbar in GMail really affects its usability and appearance. Colm

Colm Buckley

Comment 12 2009-04-17 06:22:27 PDT

Hm; I notice that this patch *does* seem to be in place in the latest WebKit source. The current binary download (r42583), though, still exhibits the horizontal scrollbar behaviour in GMail. Is there a separate issue, or is this patch not included in the binary releases? Colm

Colm Buckley

Comment 13 2009-04-17 06:53:00 PDT

Looks like a separate issue; the persistent horizontal scrollbar only appears when "right side chat" is enabled in GMail. I will investigate further.

Erik Arvidsson

Comment 14 2009-05-06 10:35:39 PDT

Gmail also uses getBoundingClientRect which is not working correctly when zoomed. Test case coming up.

Erik Arvidsson

Comment 15 2009-05-06 10:37:07 PDT

Created attachment 30056 [details] Testcase showing that getBoundingClientRect is not working correctly when zoomed Try to zoom on the page. All numbers should be 100 at all times (unless you scroll the page).

Eric Seidel (no email)

Comment 16 2009-06-02 13:44:44 PDT

Looks like this was fixed by bug 25750. Marking as a dupe. *** This bug has been marked as a duplicate of 25750 ***

Note You need to log in before you can comment on or make changes to this bug.