| Summary: | REGRESSION (r294902): Content with continuation leaves decoration bits behind when removed | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2022-06-17 17:01:44 PDT
Created attachment 460322 [details]
Patch
Created attachment 460333 [details]
Patch
Comment on attachment 460333 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460333&action=review > LayoutTests/fast/repaint/force-repaint-when-layer-is-destroyed.html:29 > + result.innerText = internals.repaintRectsAsText().indexOf("8 8 140 126") != -1 ? "PASS" : "FAIL"; This seems fragile. Maybe use a more relaxed test? Created attachment 460342 [details]
Patch
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 460333 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=460333&action=review > > > LayoutTests/fast/repaint/force-repaint-when-layer-is-destroyed.html:29 > > + result.innerText = internals.repaintRectsAsText().indexOf("8 8 140 126") != -1 ? "PASS" : "FAIL"; > > This seems fragile. This is very precise, yes. It's the exact position/size of the box that needs repainting. I am open to suggestions, but block level boxes tend no to fluctuate their position/size. Committed r295665 (251670@main): <https://commits.webkit.org/251670@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460342 [details]. |