Bug 241672

Summary:	FontCascade members m_useBackslashAsYenSymbol / m_enableKerning / m_requiresShaping don't need to be mutable
Product:	WebKit	Reporter:	Cameron McCormack (:heycam) <heycam>
Component:	Text	Assignee:	Cameron McCormack (:heycam) <heycam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	mmaxfield, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Cameron McCormack (:heycam) 2022-06-15 20:07:22 PDT

Thee fields are computed based on the FontDescription.  They're only mutable because we also update them in FontCascade::updateFonts(), but that function only updates the FontCascadeFonts pointer, not the FontDescription.  So there should be no need to update them at that time.

Comment 1 Cameron McCormack (:heycam) 2022-06-15 20:19:36 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1569

Comment 2 EWS 2022-06-16 17:52:16 PDT

Committed r295619 (251624@main): <https://commits.webkit.org/251624@main>

Reviewed commits have been landed. Closing PR #1569 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-06-16 17:53:16 PDT

<rdar://problem/95345671>