| Summary: | computeUnderlineOffset should not take InlineIterator::LineBoxIterator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 241442 | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2022-06-09 13:55:20 PDT
Created attachment 460143 [details]
Patch
Comment on attachment 460143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460143&action=review > COMMIT_MESSAGE:10 > +* Source/WebCore/style/InlineTextBoxStyle.cpp: This stuff in the wrong directory btw, it should be in rendering (or hypothetical /paint or /display). (In reply to Antti Koivisto from comment #2) > Comment on attachment 460143 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=460143&action=review > > > COMMIT_MESSAGE:10 > > +* Source/WebCore/style/InlineTextBoxStyle.cpp: > > This stuff in the wrong directory btw, it should be in rendering (or > hypothetical /paint or /display). totally! Committed r295453 (251459@main): <https://commits.webkit.org/251459@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460143 [details]. |