| Summary: | WebGPU::ShaderModule::convertCheckResult() should use std::forward | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | WebGPU | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, dino, mmaxfield, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 460102 [details]
Patch v1
Comment on attachment 460102 [details]
Patch v1
Marking as cq+ since enough builds/tests have passed.
Committed r295409 (251415@main): <https://commits.webkit.org/251415@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460102 [details]. |
WebGPU::ShaderModule::convertCheckResult() should use std::forward. Found by clang static analyzer: Source/WebGPU/WebGPU/ShaderModule.mm:125:16: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference] return WTFMove(check); ^