Bug 241437

Summary: WebGPU::ShaderModule::convertCheckResult() should use std::forward
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebGPUAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, dino, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2022-06-08 13:46:27 PDT
WebGPU::ShaderModule::convertCheckResult() should use std::forward. Found by clang static analyzer: Source/WebGPU/WebGPU/ShaderModule.mm:125:16: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference] return WTFMove(check); ^
Attachments
Patch v1 (1.16 KB, patch)
2022-06-08 14:05 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-06-08 13:46:44 PDT
<rdar://problem/94662366>
David Kilzer (:ddkilzer)
Comment 2 2022-06-08 14:05:15 PDT
Created attachment 460102 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2022-06-08 21:06:54 PDT
Comment on attachment 460102 [details] Patch v1 Marking as cq+ since enough builds/tests have passed.
EWS
Comment 4 2022-06-08 21:56:06 PDT
Committed r295409 (251415@main): <https://commits.webkit.org/251415@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460102 [details].
Note You need to log in before you can comment on or make changes to this bug.