Bug 241426

Summary: WTF::CrossThreadCopierBase::copy() should use std::forward
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web Template FrameworkAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2022-06-08 10:52:52 PDT
WTF::CrossThreadCopierBase::copy() should use std::forward. Found by clang static analyzer: In file included from OpenSource/Source/WTF/wtf/Language.cpp:29: OpenSource/Source/WTF/wtf/CrossThreadCopier.h:225:106: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference] return CrossThreadCopier<std::remove_const_t<std::remove_reference_t<decltype(type)>>>::copy(WTFMove(type)); ^
Attachments
Patch v1 (1.26 KB, patch)
2022-06-08 10:57 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-06-08 10:53:27 PDT
<rdar://problem/94648592>
David Kilzer (:ddkilzer)
Comment 2 2022-06-08 10:57:51 PDT
Created attachment 460098 [details] Patch v1
David Kilzer (:ddkilzer)
Comment 3 2022-06-08 15:00:39 PDT
Comment on attachment 460098 [details] Patch v1 Marking cq+ as enough builds and test runs have completed that I think it's safe to land this.
EWS
Comment 4 2022-06-08 16:27:04 PDT
Committed r295400 (251406@main): <https://commits.webkit.org/251406@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460098 [details].
Note You need to log in before you can comment on or make changes to this bug.