Bug 241378

Summary: Implement CSSNumericValue.equals
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: CSSAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2022-06-07 11:32:53 PDT
...
Attachments
Patch (16.75 KB, patch)
2022-06-07 11:36 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2022-06-07 11:36:28 PDT
Created attachment 460069 [details] Patch
Darin Adler
Comment 2 2022-06-07 15:11:35 PDT
Comment on attachment 460069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460069&action=review > COMMIT_MESSAGE:6 > +This is an off-by-default experimental feature. *What* is an off-by-default experimental feature? Nothing in this new code is conditional, so the experimental feature must be something this is building on.
Alex Christensen
Comment 3 2022-06-07 20:34:34 PDT
The whole CSS typed om. That's an explanation to any reviewers of why this is a super low risk change - it's all inaccessible in browsers by default.
Alex Christensen
Comment 4 2022-06-07 20:47:11 PDT
(more specifically, CSSNumericValue.equals which is specified as EnabledBySetting in CSSNumericValue.idl)
Radar WebKit Bug Importer
Comment 5 2022-06-14 11:33:13 PDT
<rdar://problem/95130832>
Chris Dumez
Comment 6 2022-06-21 12:45:53 PDT
Comment on attachment 460069 [details] Patch r=me
EWS
Comment 7 2022-06-21 20:00:42 PDT
Committed r295716 (251721@main): <https://commits.webkit.org/251721@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460069 [details].
Note You need to log in before you can comment on or make changes to this bug.