| Summary: | [LFC][FFC] Populate canUseForFlexLayout with unsupported styles and content | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, ntim, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2022-06-05 21:33:13 PDT
Created attachment 460044 [details]
[fast-cq]Patch
Comment on attachment 460044 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460044&action=review nice > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:697 > + if (flexItem.isFloating() || flexItem.isOutOfFlowPositioned()) I'm pretty sure `float` has no effect on flex items. See: data:text/html,<div style="display: flex;"><div style="float: right; width: 200px; height: 200px; background: red"></div></div> or data:text/html,<div style="display: flex;">dsdfdsofjdskfdslvndlcvnfsldjnvdfoskgdfjngfdjnfdljgksdfngfdlg<div style="float: left; width: 200px; height: 200px; background: red"></div></div> I could be wrong though Committed r295282 (251328@main): <https://commits.webkit.org/251328@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460044 [details]. |