| Summary: | [LFC][FFC] column-reverse content should take resolved flex box height into account when computing visual position | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, ntim, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2022-06-04 20:43:56 PDT
Created attachment 460034 [details]
Patch
Comment on attachment 460034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=460034&action=review > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:268 > + auto pyhsicalBottom = constraints.logicalTop() + constraints.availableVerticalSpace().value_or(logicalWidth); pyhsical Created attachment 460036 [details]
Patch
(In reply to Tim Nguyen (:ntim) from comment #2) > Comment on attachment 460034 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=460034&action=review > > > Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:268 > > + auto pyhsicalBottom = constraints.logicalTop() + constraints.availableVerticalSpace().value_or(logicalWidth); > > pyhsical lol, so this made me change it to my preferred term of 'visual". Committed r295273 (251319@main): <https://commits.webkit.org/251319@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 460036 [details]. |